Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39087: Add PyUnicode_GetUTF8Buffer(). #17659

Open
wants to merge 5 commits into
base: master
from

Conversation

@methane
Copy link
Member

methane commented Dec 19, 2019

Ref: bpo-39087

@methane methane requested a review from python/windows-team as a code owner Dec 19, 2019
@methane methane requested review from vstinner and serhiy-storchaka Dec 19, 2019
Lib/test/test_unicode.py Outdated Show resolved Hide resolved
Lib/test/test_unicode.py Outdated Show resolved Hide resolved
Lib/test/test_unicode.py Outdated Show resolved Hide resolved
Modules/_testcapimodule.c Outdated Show resolved Hide resolved
Doc/c-api/unicode.rst Show resolved Hide resolved
Objects/unicodeobject.c Show resolved Hide resolved
Objects/unicodeobject.c Show resolved Hide resolved
methane added 3 commits Dec 20, 2019
from _testcapi import unicode_getutf8buffer, test_unicode_getutf8buffer

# Run tests wrtten in C. Raise an error when test failed.
test_unicode_getutf8buffer()

This comment has been minimized.

Copy link
@vstinner

vstinner Dec 20, 2019

Member

Hum. test_capi executes all test_capi attributes with a name starting with "test_". Please check if it's executed. If yes, just rename the method. For example, rename it to unicode_test_getutf8buffer()).

This comment has been minimized.

Copy link
@methane

methane Dec 20, 2019

Author Member

You are right. I confirmed the test_unicode_getutf8buffer is called from test_capi.

I just removed calling test_unicode_getutf8buffer here because there is test_unicode_compare_with_ascii already.
Let's run the test from test_capi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.