Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39102: Increase Enum performance up to 10x times (3x average) #17669
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 20, 2019
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
MrMrRobat commentedDec 20, 2019
•
edited
Increase Enum performance
https://bugs.python.org/issue39102
Partial benchmark result, to see more, check full benchmark result and source code
Full benchmark result and source code
ToDo:
Also, does compatibility with python <3.6 need to be maintained?
If not, we could use type annotations forname
andvalues
attrs. (However I wasn't able to importtyping.Any
inenum
module due to circular import)Ok, I see that there are no type annotations in
stdlib
at all, but the question is still valid, because if compatibility doesn't need to be maintained, we could use the fact that python 3.8 dicts and sets which are preserve order to speed things up even more.https://bugs.python.org/issue39102