Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37228: Add whatsnew for removal of loop.create_datagram_endpoint()'s *reuse_address* parameter #17595

Merged
merged 1 commit into from Dec 16, 2019
Merged

bpo-37228: Add whatsnew for removal of loop.create_datagram_endpoint()'s *reuse_address* parameter #17595

merged 1 commit into from Dec 16, 2019

Conversation

@aeros
Copy link
Member

aeros commented Dec 14, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue37228
@aeros
Add whatsnew for removal of asyncio.loop.create_datagram_endpoint()'s…
Loading status checks…
d9bb4c1 
… *reuse_address* parameter
@aeros aeros requested review from ambv and ned-deily Dec 14, 2019
@aeros aeros requested review from 1st1 and asvetlov Dec 14, 2019
@ned-deily
ned-deily reviewed Dec 14, 2019
View changes
Copy link
Member

ned-deily left a comment

LGTM, thanks!
@aeros

This comment has been minimized.

Sign in to view
Copy link
Member Author

aeros commented Dec 14, 2019 •
edited

@1st1 and/or @asvetlov, would you mind giving this a final look-over before we add these whatsnews entries? Since it's a backwards incompatible change to asyncio affecting multiple versions (for anyone passing reuse_address=True to loop.create_datagram_endpoint()), I want to make sure we communicate it as well as possible.

Is the current iteration adequate or should it be more specific? My goal was to avoid adding too many details in the whatsnew entry and explain most of it in the documentation.
@1st1 1st1 merged commit f501db2 into python:master Dec 16, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191214.4 succeeded
Details
bedevere/issue-number Issue number 37228 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 16, 2019

@1st1: Please replace # with GH- in the commit message next time. Thanks!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 16, 2019

Thanks @aeros for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8.
🐍🍒⛏🤖
@1st1

This comment has been minimized.

Sign in to view
Copy link
Member

1st1 commented Dec 16, 2019

Thank you, Kyle! Apologies for the wait!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 16, 2019

Sorry, @aeros and @1st1, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f501db2b93a9d3d840b6fb38d6bdda8bcc400d4a 3.8
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 16, 2019

Sorry @aeros and @1st1, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f501db2b93a9d3d840b6fb38d6bdda8bcc400d4a 3.7
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 16, 2019

Sorry, @aeros and @1st1, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f501db2b93a9d3d840b6fb38d6bdda8bcc400d4a 3.6
@1st1

This comment has been minimized.

Sign in to view
Copy link
Member

1st1 commented Dec 16, 2019

@aeros Kyle, could you please manually backport the PR?
@aeros

This comment has been minimized.

Sign in to view
Copy link
Member Author

aeros commented Dec 16, 2019

@1st1

Thank you, Kyle! Apologies for the wait!

No problem. (:

Kyle, could you please manually backport the PR?

Yep, and I'll add you as a reviewer for the backports.
aeros added a commit to aeros/cpython that referenced this pull request Dec 16, 2019
@aeros
[3.8] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
71aab00 
…nt()'s *reuse_address* parameter (pythonGH-17595).

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
aeros added a commit to aeros/cpython that referenced this pull request Dec 16, 2019
@aeros
[3.7] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
fa64fb8 
…nt()'s *reuse_address* parameter (pythonGH-17595).

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
aeros added a commit to aeros/cpython that referenced this pull request Dec 16, 2019
@aeros
[3.6] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
3108de9 
…nt()'s *reuse_address* parameter (pythonGH-17595).

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
ned-deily added a commit that referenced this pull request Dec 16, 2019
@aeros @ned-deily
[3.6] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
Loading status checks…
50fc84a 
…nt()'s *reuse_address* parameter (GH-17595). (GH-17632)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
ned-deily added a commit that referenced this pull request Dec 17, 2019
@aeros @ned-deily
[3.8] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
Loading status checks…
a96e938 
…nt()'s *reuse_address* parameter (GH-17595). (#17630)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
ned-deily added a commit that referenced this pull request Dec 17, 2019
@aeros @ned-deily
[3.7] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
Loading status checks…
8a06c9e 
…nt()'s *reuse_address* parameter (GH-17595). (GH-17631)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
@sthagen sthagen mentioned this pull request Dec 17, 2019
Merged
ned-deily added a commit to ned-deily/cpython that referenced this pull request Dec 18, 2019
@aeros @ned-deily
[3.7] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
3413f5c 
…nt()'s *reuse_address* parameter (pythonGH-17595). (pythonGH-17631)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

@ambv ambv

@1st1 1st1

@asvetlov asvetlov

Assignees

@1st1 1st1

Labels
CLA signed needs backport to 3.6 needs backport to 3.7 needs backport to 3.8 skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@aeros @bedevere-bot @miss-islington @1st1 @ned-deily @the-knights-who-say-ni
You can’t perform that action at this time.