Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38546: multiprocessing tests stop the resource tracker #17641
+42
−21
Conversation
Multiprocessing and concurrent.futures tests now stop the resource tracker process when tests complete. Add ResourceTracker._stop() method to multiprocessing.resource_tracker. Add _cleanup_tests() helper function to multiprocessing.util: share code between multiprocessing and concurrent.futures tests.
This comment has been minimized.
This comment has been minimized.
vstinner
merged commit 9707e8e
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 17, 2019
|
Thanks @vstinner for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 17, 2019
|
Sorry, @vstinner, I could not cleanly backport this to |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Dec 17, 2019
…17641) Multiprocessing and concurrent.futures tests now stop the resource tracker process when tests complete. Add ResourceTracker._stop() method to multiprocessing.resource_tracker. Add _cleanup_tests() helper function to multiprocessing.util: share code between multiprocessing and concurrent.futures tests. (cherry picked from commit 9707e8e)
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 17, 2019
|
GH-17647 is a backport of this pull request to the 3.8 branch. |
vstinner
added a commit
that referenced
this pull request
Dec 18, 2019
…GH-17647) Multiprocessing and concurrent.futures tests now stop the resource tracker process when tests complete. Add ResourceTracker._stop() method to multiprocessing.resource_tracker. Add _cleanup_tests() helper function to multiprocessing.util: share code between multiprocessing and concurrent.futures tests. (cherry picked from commit 9707e8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedDec 17, 2019
•
edited by bedevere-bot
Multiprocessing tests now stop the resource tracker process, to
prevent leaking a child process after tests complete.
Add _cleanup_tests() helper function to multiprocessing.util: share
code between multiprocessing and concurrent.futures tests.
https://bugs.python.org/issue38546