Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() #17652
Conversation
Fix test_ressources_gced_in_workers() of test_concurrent_futures: explicitly stop the manager to prevent leaking a child process running in the background after the test completes.
This comment has been minimized.
This comment has been minimized.
|
It took me two months to identify this bug. It would be nice to automatically detects such bug in tests, but I'm not sure how to do that. |
|
LGTM |
vstinner
merged commit 673c393
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 18, 2019
|
Thanks @vstinner for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2019
…ythonGH-17652) Fix test_ressources_gced_in_workers() of test_concurrent_futures: explicitly stop the manager to prevent leaking a child process running in the background after the test completes. (cherry picked from commit 673c393) Co-authored-by: Victor Stinner <vstinner@python.org>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 18, 2019
|
GH-17653 is a backport of this pull request to the 3.8 branch. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 18, 2019
|
GH-17654 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2019
…ythonGH-17652) Fix test_ressources_gced_in_workers() of test_concurrent_futures: explicitly stop the manager to prevent leaking a child process running in the background after the test completes. (cherry picked from commit 673c393) Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Dec 18, 2019
…ythonGH-17652) Fix test_ressources_gced_in_workers() of test_concurrent_futures: explicitly stop the manager to prevent leaking a child process running in the background after the test completes. (cherry picked from commit 673c393)
vstinner
added a commit
that referenced
this pull request
Dec 18, 2019
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2019
…ythonGH-17652) (pythonGH-17655) Fix test_ressources_gced_in_workers() of test_concurrent_futures: explicitly stop the manager to prevent leaking a child process running in the background after the test completes. (cherry picked from commit 673c393) (cherry picked from commit b0eb046) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
added a commit
that referenced
this pull request
Dec 18, 2019
…H-17652) (GH-17655) Fix test_ressources_gced_in_workers() of test_concurrent_futures: explicitly stop the manager to prevent leaking a child process running in the background after the test completes. (cherry picked from commit 673c393) (cherry picked from commit b0eb046) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedDec 18, 2019
•
edited by bedevere-bot
Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.
https://bugs.python.org/issue38546