Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39099: add scandir.dirfd() #17664
Open
+40
−0
Conversation
I see that the BPO issue has been closed, but I have some comments anyway. :) |
fd = dirfd(self->dirp); | ||
if (fd == -1) | ||
return path_error(&self->path); | ||
return Py_BuildValue("i", fd); |
This comment has been minimized.
This comment has been minimized.
PyErr_SetString(PyExc_ValueError, "I/O operation on closed directory"); | ||
return NULL; | ||
} | ||
fd = dirfd(self->dirp); |
This comment has been minimized.
This comment has been minimized.
@@ -169,6 +169,9 @@ Exposed the Linux-specific :func:`os.pidfd_open` (:issue:`38692`) and | |||
:data:`os.P_PIDFD` (:issue:`38713`) for process management with file | |||
descriptors. | |||
|
|||
Added :meth:`~os.scandir.dirfd` method. |
This comment has been minimized.
This comment has been minimized.
@@ -0,0 +1,2 @@ | |||
os.scandir() object has a new dirfd() method. (patch contributed by |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
giampaolo commentedDec 19, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39099
https://bugs.python.org/issue39099