Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-31904: Add cross-build support for VxWorks RTOS #11968
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Feb 21, 2019
bedevere-bot
added
the
awaiting review
label
Feb 21, 2019
vstinner
reviewed
Feb 21, 2019
setup.py Outdated
vstinner
reviewed
Feb 22, 2019
configure.ac Outdated
vstinner
requested changes
Feb 25, 2019
bedevere-bot
added
awaiting changes
and removed
awaiting review
labels
Feb 25, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 25, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This comment has been minimized.
This comment has been minimized.
I have made the requested changes; please review again |
bedevere-bot
added
awaiting change review
and removed
awaiting changes
labels
Feb 26, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 26, 2019
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
pxinwr
referenced this pull request
Feb 26, 2019
Merged
bpo-31904: Add encoding support for VxWorks RTOS #12051
vstinner
reviewed
Feb 26, 2019
LGTM except of 2 minor changes: please fix NEWS entry and variable name. |
@@ -44,6 +44,8 @@ def get_platform(): | |||
return sys.platform | |||
host_platform = get_platform() | |||
|
|||
_vxworks = ('vxworks' in host_platform) |
This comment has been minimized.
This comment has been minimized.
vstinner
Feb 26, 2019
Member
Please rename the variable to VXWORKS to better distinguish local and global variables in functions below.
By the way, I would also prefer to rename host_platform to HOST_PLATFORM for the same reason, but it should be done in a separated PR.
This comment has been minimized.
This comment has been minimized.
pxinwr
Feb 27, 2019
Author
Contributor
Just to confirm: all the variables that are not supposed to be modified should be defined as constants, right? If this is true, besides host_platform, cross_compiling is another one to fix. I looked through PEP-8 but didn't find the guidance.
pxinwr
added some commits
Feb 27, 2019
This comment has been minimized.
This comment has been minimized.
Out of curiosity, does CPython run LGTM analysis as well? |
This comment has been minimized.
This comment has been minimized.
Are you talking about lgtm.com? I know that Mark Shannon is working for this company, and I know that CPython is scanned by lgtm.com. Sadly, I never looked at it. |
This comment has been minimized.
This comment has been minimized.
Ah, I found it: https://lgtm.com/projects/g/python/cpython/ |
vstinner
merged commit 32f5fdd
into
python:master
Feb 27, 2019
4 of 5 checks passed
bedevere-bot
removed
the
awaiting change review
label
Feb 27, 2019
This comment has been minimized.
This comment has been minimized.
Thanks @pxinwr, I merged your PR ;-) |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Feb 27, 2019
|
This comment has been minimized.
This comment has been minimized.
I wrote PR #12068 as a follow-up of this PR. |
This comment has been minimized.
This comment has been minimized.
About buildbot failures: I guess that most if not all of them are caused by the FTP server issue, https://bugs.python.org/issue36131 |
pxinwr commentedFeb 21, 2019
•
edited by bedevere-bot
This PR enables cpython build system to cross-build for VxWorks RTOS. More and full support on modules for VxWorks will continuously be added by the coming PRs.
VxWorks is a product developed and owned by Wind River. For VxWorks introduction or more details, go to https://www.windriver.com/products/vxworks/
Wind River will have a dedicated engineering team to contribute to the support as maintainers.
We already have a working buildbot worker internally, but has not bound to master. We will check the process for the buildbot, then add it.
https://bugs.python.org/issue31904