Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmetic smtplib changes #8718

Merged
merged 2 commits into from May 23, 2020
Merged

Cosmetic smtplib changes #8718

merged 2 commits into from May 23, 2020

Conversation

scop
Copy link
Contributor

@scop scop commented Aug 9, 2018 •
edited by miss-islington

Some cosmetic smtplib changes here. Let me know if you'd like a bpo/news entry or splitting this PR into two.

Automerge-Triggered-By: @maxking

Automerge-Triggered-By: @csabella

@scop scop requested a review from a team as a code owner Aug 9, 2018
@scop scop mentioned this pull request Aug 9, 2018
Merged
@csabella csabella requested review from a team and removed request for a team May 19, 2019
@matrixise matrixise self-assigned this Sep 14, 2019
@csabella csabella requested a review from maxking Dec 13, 2019
@maxking
Copy link
Contributor

maxking commented Dec 13, 2019

I think the changes make sense, I am going to merge these.

Thanks @scop for your contribution!

@maxking maxking added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 13, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Dec 13, 2019

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

@maxking maxking removed the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 13, 2019
@maxking
Copy link
Contributor

maxking commented Dec 13, 2019

It looks to me like Azure Pipelines PR is stuck :(

@bitdancer
Copy link
Member

bitdancer commented Dec 13, 2019

We didn't used to accept cosmetic changes like this unless there were other bugs being fixed in the same area. Well, the doc change is fine. The other seems safe as well, so I don't object to merging it, I just want to note that the CPython culture at least used to be "don't make code changes unless you are fixing a bug nearby". :)

@maxking
Copy link
Contributor

maxking commented Dec 13, 2019

@bitdancer I thought that the conversion from 0/1 to False/True would be useful too so I ended up approving the changes :)

@maxking maxking closed this Dec 23, 2019
@maxking maxking reopened this Dec 23, 2019
@csabella csabella added the 🤖 automerge PR will be merged once it's been approved and all CI passed label May 23, 2020
@miss-islington miss-islington merged commit da51ba4 into python:master May 23, 2020
@csabella
Copy link
Contributor

csabella commented May 23, 2020

Added automerge as @maxking had approved this and was just waiting for the CI to pass.

@scop scop deleted the smtplib-cosmetic branch May 23, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@scop @arturoescaip
Cosmetic smtplib changes (pythonGH-8718)
1978f8f 
Some cosmetic smtplib changes here. Let me know if you'd like a bpo/news entry or splitting this PR into two.

Automerge-Triggered-By: @maxking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxking maxking

Assignees

@matrixise matrixise

Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@scop @maxking @miss-islington @bitdancer @csabella @matrixise @the-knights-who-say-ni @bedevere-bot