Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to avoid ACKS losing order #17678

Merged
merged 1 commit into from Dec 23, 2019
Merged

Add comment to avoid ACKS losing order #17678

merged 1 commit into from Dec 23, 2019

Conversation

@merwok
Copy link
Contributor

merwok commented Dec 21, 2019

See #17663 (comment)
@merwok
Add comment to avoid ACKS losing order
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2a7a43
@merwok merwok requested a review from serhiy-storchaka Dec 21, 2019
@tirkarthi
tirkarthi approved these changes Dec 23, 2019
View changes
Copy link
Contributor

tirkarthi left a comment

LGTM. Thanks.
@merwok merwok changed the title Add comment to avoid ACKS losing order Add comment to avoid ACKS losing order (GH-17678) Dec 23, 2019
@merwok merwok merged commit 3c75f31 into master Dec 23, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191221.8 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@merwok merwok deleted the misc-acks-comment branch Dec 23, 2019
@merwok merwok changed the title Add comment to avoid ACKS losing order (GH-17678) Add comment to avoid ACKS losing order Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
4 participants
@merwok @tirkarthi @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.