Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] Move _releaseLock() into `finally` #17689

Draft
wants to merge 1 commit into
base: master
from

Conversation

@DerekTBrown
Copy link

DerekTBrown commented Dec 24, 2019

No description provided.

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Dec 24, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@DerekTBrown

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@DerekTBrown DerekTBrown force-pushed the DerekTBrown:logging_deadlock branch 2 times, most recently from 53e9f6b to 9509cc9 Dec 24, 2019
@DerekTBrown DerekTBrown changed the title Fix potential deadlock in logging [easy] Move _releaseLock() into `finally` Dec 24, 2019
@DerekTBrown DerekTBrown force-pushed the DerekTBrown:logging_deadlock branch from 9509cc9 to d9dbc31 Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.