bpo-29602: fix signed zero handling in complex constructor. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
added
type-bug
serhiy-storchaka
approved these changes
Feb 20, 2017
mdickinson
added a commit
to mdickinson/cpython
that referenced
this pull request
Feb 20, 2017
* Fix incorrect handling of signed zeros for complex-related classes. * Add Misc/NEWS entry. (cherry picked from commit 112ec38)
mdickinson
added a commit
to mdickinson/cpython
that referenced
this pull request
Feb 20, 2017
* Fix incorrect handling of signed zeros for complex-related classes. * Add Misc/NEWS entry. (cherry picked from commit 112ec38)
This was referenced Feb 20, 2017
mdickinson
added a commit
that referenced
this pull request
Feb 20, 2017
mdickinson
added a commit
that referenced
this pull request
Feb 20, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 6, 2019
instead of _PyRuntime.st.try_stackless.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 12, 2019
instead of _PyRuntime.st.try_stackless.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR, based on a patch by Serhiy Storchaka, fixes the issues with signed zeros identified in http://bugs.python.org/issue29602:
class A(object)implementing__complex__,complex(A())ignored the sign of a negative zero in the imaginary partclass C(complex), construction of aCinstance from acomplexinstance also ignored the sign of a negative zero in the imaginary part.