Skip to content

Fix typo in asynchronous generator iterator documentation #10542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix typo in asynchronous generator iterator documentation #10542

merged 1 commit into from
Nov 15, 2018

Conversation

tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Nov 14, 2018 •
edited by Mariatta
Loading

Remove an unnecessary "that":
... will execute that the body ... -> ... will execute the body ...

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 14, 2018
@Mariatta
Copy link
Member

Thanks. Waiting for CLA.

@tiangolo
Copy link
Contributor Author

Thanks! I just signed it an hour ago or so. So I guess it will appear in a couple of days.

@Mariatta Mariatta changed the title Typo: docs -> glossary -> asynchronous generator iterator Fix typo in asynchronous generator iterator documentation Nov 14, 2018
@Mariatta Mariatta changed the title Fix typo in asynchronous generator iterator documentation Typo: docs -> glossary -> asynchronous generator iterator Nov 14, 2018
@Mariatta
Copy link
Member

Thanks, please recheck the CLA in a day. After that, this will get automatically merged.
Thanks again and congrats on your first contribution to CPython 🌮

@Mariatta Mariatta changed the title Typo: docs -> glossary -> asynchronous generator iterator Fix typo in asynchronous generator iterator documentation Nov 14, 2018
@miss-islington miss-islington merged commit 25221b3 into python:master Nov 15, 2018
@miss-islington
Copy link
Contributor

Thanks @tiangolo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2018
@tiangolo @miss-islington
Fix typo in asynchronous generator iterator documentation (pythonGH-1…
fe9eaf2 
…0542)

Remove an unnecessary "that":
... will execute that the body ... ->  ... will execute the body ...
(cherry picked from commit 25221b3)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
@bedevere-bot
Copy link

GH-10553 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2018
@tiangolo @miss-islington
Fix typo in asynchronous generator iterator documentation (pythonGH-1…
803d26d 
…0542)

Remove an unnecessary "that":
... will execute that the body ... ->  ... will execute the body ...
(cherry picked from commit 25221b3)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
@bedevere-bot
Copy link

GH-10554 is a backport of this pull request to the 3.6 branch.

@tiangolo tiangolo deleted the fix-glossary-async-gen-iter-typo branch November 15, 2018 05:53
miss-islington added a commit that referenced this pull request Nov 15, 2018
@miss-islington @tiangolo
Fix typo in asynchronous generator iterator documentation (GH-10542)
b6b56b4 
Remove an unnecessary "that":
... will execute that the body ... ->  ... will execute the body ...
(cherry picked from commit 25221b3)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
miss-islington added a commit that referenced this pull request Nov 15, 2018
@miss-islington @tiangolo
Fix typo in asynchronous generator iterator documentation (GH-10542)
10a8e11 
Remove an unnecessary "that":
... will execute that the body ... ->  ... will execute the body ...
(cherry picked from commit 25221b3)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiangolo @the-knights-who-say-ni @Mariatta @miss-islington @bedevere-bot