Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-24416: [DO NOT MERGE] Return a namedtuple from date.isocalendar() with structseq version #17651
+231
−28
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
corona10 commentedDec 18, 2019
•
edited by bedevere-bot
This is PoC PR from https://github.com/python/cpython/pull/15633/files#r358645767
Past trial 752aad8 which overriding
__reduce__was not proper since it affect to all structsequnce type.So this is another trial that overriding
reducewhen initializing StructIsoCalendarDateType.I checked that this change does not change any behavior of other StructSequence types.
https://bugs.python.org/issue24416