[3.8] bpo-38270: Fix indentation of test_hmac assertions (GH-17446) #17450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac. This PR fixes it. As the change is quite trivial I didn't add a NEWS entry. https://bugs.python.org/issue38270 (cherry picked from commit 8943318) Co-authored-by: stratakis <cstratak@redhat.com>
|
@stratakis: Status check is done, and it's a success ✅ . |
2 similar comments
|
@stratakis: Status check is done, and it's a success ✅ . |
|
@stratakis: Status check is done, and it's a success ✅ . |
eamanu
approved these changes
Dec 3, 2019
tiran
approved these changes
Dec 5, 2019
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Dec 12, 2019
) (pythonGH-17450) Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac. This PR fixes it. As the change is quite trivial I didn't add a NEWS entry. https://bugs.python.org/issue38270 (cherry picked from commit 8943318) Co-authored-by: stratakis <cstratak@redhat.com> https://bugs.python.org/issue38270 Automerge-Triggered-By: @tiran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since c64a1a6 two assertions were indented and thus ignored when running test_hmac.
This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.
https://bugs.python.org/issue38270
(cherry picked from commit 8943318)
Co-authored-by: stratakis cstratak@redhat.com
https://bugs.python.org/issue38270
Automerge-Triggered-By: @tiran