Skip to content

bpo-38778: Document that os.fork is not allowed in subinterpreters #17123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 15, 2019
Merged

bpo-38778: Document that os.fork is not allowed in subinterpreters #17123

merged 6 commits into from
Nov 15, 2019

Conversation

phmc
Copy link
Contributor

@phmc phmc commented Nov 12, 2019 •
edited by miss-islington
Loading

Small docs update for bpo-34651.

Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed.

https://bugs.python.org/issue38778

Automerge-Triggered-By: @ericsnowcurrently

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@phmc

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 12, 2019
@gpshead
Copy link
Member

gpshead commented Nov 12, 2019

Could you add a versionchanged marker in the docs for this?

@brandtbucher
Copy link
Member

Thanks for your time @phmc, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

brandtbucher
brandtbucher approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of minor suggestions, but otherwise this looks good:

@phmc
Copy link
Contributor Author

phmc commented Nov 13, 2019

Thanks guys. Just needed to associate my github account with my bpo account (I've not contributed anything since the hg days :))

I've changed the note to a versionchanged (didn't seem helpful to keep both) and incorporated Brandt's suggestions.

@brandtbucher
Copy link
Member

Thanks @phmc!

The Travis failure looks like an issue on their end, unrelated to your changes. Pushing to your branch or closing-and-reopening this PR (not making a new one) should re-trigger the build.

brandtbucher
brandtbucher approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@phmc phmc closed this Nov 14, 2019
@phmc phmc reopened this Nov 14, 2019
@phmc
Copy link
Contributor Author

phmc commented Nov 14, 2019

Gave travis a kick as suggested by Brandt, looks like everything has come back clean now.

ericsnowcurrently
ericsnowcurrently approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI, I basically copied-and-pasted your text for the forkpty() doc entry.

Also, there are some related changed to be made to the C-API docs, but I'll do that separately.

@miss-islington
Copy link
Contributor

@phmc: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b220300 into python:master Nov 15, 2019
@miss-islington
Copy link
Contributor

Thanks @phmc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@brandtbucher
Copy link
Member

Congrats on your first CPython contribution @phmc! 🍾

Looking forward to seeing more from you in the future.

@miss-islington
Copy link
Contributor

Thanks @phmc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @phmc, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b22030073b9327a3aeccb69507694bce078192aa 3.8

@miss-islington miss-islington self-assigned this Nov 15, 2019
@miss-islington
Copy link
Contributor

Thanks @phmc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2019
@phmc @miss-islington
bpo-38778: Document that os.fork is not allowed in subinterpreters (p…
71bfbd1 
…ythonGH-17123)

Small docs update for [bpo-34651](https://bugs.python.org/issue34651).

Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed.

https://bugs.python.org/issue38778

Automerge-Triggered-By: @ericsnowcurrently
(cherry picked from commit b220300)

Co-authored-by: Phil Connell <pconnell@gmail.com>
@bedevere-bot
Copy link

GH-17179 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 15, 2019
@miss-islington @phmc
bpo-38778: Document that os.fork is not allowed in subinterpreters (G…
a4be5aa 
…H-17123)

Small docs update for [bpo-34651](https://bugs.python.org/issue34651).

Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed.

https://bugs.python.org/issue38778

Automerge-Triggered-By: @ericsnowcurrently
(cherry picked from commit b220300)

Co-authored-by: Phil Connell <pconnell@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@phmc
bpo-38778: Document that os.fork is not allowed in subinterpreters (p…
e519e91 
…ythonGH-17123)

Small docs update for [bpo-34651](https://bugs.python.org/issue34651).

Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed.





https://bugs.python.org/issue38778



Automerge-Triggered-By: @ericsnowcurrently
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@phmc @shihai1991
bpo-38778: Document that os.fork is not allowed in subinterpreters (p…
f7de0b4 
…ythonGH-17123)

Small docs update for [bpo-34651](https://bugs.python.org/issue34651).

Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed.





https://bugs.python.org/issue38778



Automerge-Triggered-By: @ericsnowcurrently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@phmc @the-knights-who-say-ni @gpshead @brandtbucher @miss-islington @bedevere-bot @ericsnowcurrently