Skip to content

bpo-33541: Remove unused __pad function #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2018
Merged

bpo-33541: Remove unused __pad function #4377

merged 2 commits into from
May 20, 2018

Conversation

mariocj89
Copy link
Contributor

@mariocj89 mariocj89 commented Nov 12, 2017 •
edited by bedevere-bot
Loading

The function was added with the initial implementation 00efe7e.

Should be safe to remove as it is private and mangled.

https://bugs.python.org/issue33541

@mariocj89
Remove unused function '__pad'
34bd8ba 
Function was added with the initial implementation 00efe7e.

Should be safe to remove as it is private and mangled.
@encukou
Copy link
Member

encukou commented May 16, 2018

I don't think this needs a NEWS entry, but it does have the potential to break some code. It's been around for some time.
Can you create an issue on bugs.python.org, as a place for discussion?

@mariocj89 mariocj89 changed the title Remove unused __pad function bpo-33541: Remove unused __pad function May 16, 2018
@mariocj89
Copy link
Contributor Author

mariocj89 commented May 16, 2018 •
edited
Loading

Thanks @encukou, Created the issue for discussion. The function is mangled so I'd be surprised if anything was using it though

@encukou
Copy link
Member

encukou commented May 16, 2018

I talked to Łukasz, the Python 3.8 release manager, and he said this does need a NEWS entry. I added one. Sorry for the confusion!

@encukou encukou removed the skip news label May 16, 2018
encukou
encukou approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to merge this after CI checks finish.

@abalkin abalkin self-assigned this May 20, 2018
@abalkin abalkin merged commit 89a25ce into python:master May 20, 2018
@mariocj89 mariocj89 deleted the __pad branch September 14, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@grimreaper grimreaper grimreaper approved these changes

Assignees

@abalkin abalkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mariocj89 @encukou @grimreaper @abalkin @the-knights-who-say-ni @bedevere-bot