Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unittest.mock.rst #17674

Open
wants to merge 1 commit into
base: 3.6
from
Open

Update unittest.mock.rst #17674

wants to merge 1 commit into from

Conversation

@drewmarshburn
Copy link

drewmarshburn commented Dec 20, 2019

Small grammatical change.

Small grammatical change.
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Dec 20, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@drewmarshburn

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bharel
bharel approved these changes Dec 21, 2019
Copy link
Contributor

bharel left a comment

Only to Python 3.6? Why not master?

@tirkarthi

This comment has been minimized.

Copy link
Contributor

tirkarthi commented Dec 21, 2019

Please raise PRs to master unless it's an issue with the specific release branch. 3.6 accepts only security patches. As for the change I am not a native speaker but both versions sound same to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.