Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39131 email: add easier support for generating multipart/signed messages #17695
Conversation
This commit adds a specific class for multipart/signed MIME parts and support for it in the Generator. The user gets a class which can be instantiated with a helper function that will be called during the serialization of messages, at the point where the subparts of this multipart object have been serialized. This way, the user can calculate a signature over the message and be sure it will be sent out like this.
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 24, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
jap commentedDec 24, 2019
•
edited by bedevere-bot
When creating multipart/signed messages, this currently require two serialisation passes: once to extract the flattened contents to be signed, and once to actually serialise the message.
This PR contains a new class, MIMEMultipartSigned, which can be instantiated with a signer function that can perform the signing while serialising, reducing this to only once.
Besides, this ensures that the signed contents cannot changed between signing and outputting.
https://bugs.python.org/issue39131