Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReorder entries in Misc/ACKS #17663
Reorder entries in Misc/ACKS #17663
Conversation
Dan Lidral-Porter | ||
Ngalim Siregar | ||
Tim Gates | ||
Karthikeyan Singaravelan |
This comment has been minimized.
This comment has been minimized.
merwok
Dec 19, 2019
Author
Contributor
12 lines added, 13 lines removed because Ngalim Siregar was already in the right spot.
Thank you! I was going to do this myself, it was in my low priority list. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 20, 2019
@merwok: Please replace |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 20, 2019
Thanks @merwok for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 20, 2019
Sorry, @merwok, I could not cleanly backport this to |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 20, 2019
Sorry @merwok, I had trouble checking out the |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 20, 2019
GH-17672 is a backport of this pull request to the 3.7 branch. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 20, 2019
GH-17673 is a backport of this pull request to the 3.8 branch. |
This comment has been minimized.
This comment has been minimized.
Thanks for review. If the problem comes again, we could add a comment at the end of the file. |
This comment has been minimized.
This comment has been minimized.
Nice idea about a comment at the end of the file! |
reorder entries in Misc/ACKS (python#17663)
This comment has been minimized.
This comment has been minimized.
Sorry, being the latest entry added by myself I read the sorted nature of the file at the top but didn't that it was sorted by last name expecting sorted by first name. It's a good idea to add the comment in the end about the same. I tried adding a check to Thanks. |
This comment has been minimized.
This comment has been minimized.
The order is not 100% exact, so I think trying to make an automated order would be hard (e.g. if there are three bits in the name, could be two first names or a two-part last name). Let me make a PR to add the comment at the end and add it to the backports PRs too (and please review these!) |
merwok commentedDec 19, 2019
No description provided.