Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.9.0a2.rst - correct small typos #17665

Merged
merged 1 commit into from Dec 25, 2019
Merged

Update 3.9.0a2.rst - correct small typos #17665

merged 1 commit into from Dec 25, 2019
+7 −9

Conversation

@toonarmycaptain
Copy link
Contributor

toonarmycaptain commented Dec 19, 2019 •
edited by miss-islington

Small typo/formatting corrections.
whethen -> whether
exaustion' -> exhaustionAssorted appending periods.and slight reformattings to placePath contributed by` on the same line as description, matching the majority of document.

NB Some of these might need to be backported, as I saw the first error in the changelog for 3.8.1

Automerge-Triggered-By: @asvetlov
@toonarmycaptain
Update 3.9.0a2.rst - correct small typos
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8cb675c 
Small typo/formatting corrections.
`whethen` -> `whether` 
`exaustion' -> `exhaustion`
Assorted appending periods `.` and slight reformattings to place `Path contributed by` on the same line as description, matching the majority of document.
@tirkarthi
tirkarthi reviewed Dec 21, 2019
View changes
Copy link
Contributor

tirkarthi left a comment

Thanks for the catch. Some more I found while reviewing :

asolute -> absolute
importliib -> importlib
happend -> happened
Excape -> Escape

* In Python 3.9.0a1, sys.argv[0] was made an asolute  path if a filename was
* Update importliib.metadata to include improvements from importlib_metadata
1.3 including better serialization of EntryPoints and improved documentation
* AsyncMock fix for return values that are awaitable types.  This also covers
side_effect iterable values that happend to be awaitable, and wraps
callables that return an awaitable type. Before these awaitables were being
awaited instead of being returned as is.
for custom finders.
* Excape key now closes IDLE completion windows.  Patch by Johnny Najera.
@asvetlov
asvetlov approved these changes Dec 25, 2019
View changes
@asvetlov

This comment has been minimized.

Sign in to view
Copy link
Contributor

asvetlov commented Dec 25, 2019

The PR improves things, it deserves to be applied.
Other errors can be fixed separately.
@miss-islington miss-islington merged commit dd117c3 into python:master Dec 25, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191219.16 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@asvetlov asvetlov

Assignees
No one assigned
Labels
🤖 automerge CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@toonarmycaptain @asvetlov @tirkarthi @the-knights-who-say-ni @bedevere-bot @miss-islington
You can’t perform that action at this time.