Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login via Google doesn't work #41

Closed
vstinner opened this issue Dec 16, 2019 · 9 comments
Closed

Login via Google doesn't work #41

vstinner opened this issue Dec 16, 2019 · 9 comments

Comments

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 16, 2019

@isidentical wrote at python/cpython#17612 (comment) :

Yes but currently I can only reply through mail because bpo logins with
google doesnt work. And if needed I can implement this lazy loading idea i
proposed earlier.

@isidentical
Copy link
Member

@isidentical isidentical commented Dec 16, 2019

Thanks for reporting it @vstinner. This is the message I get when i try to login;
image

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Dec 17, 2019

Two issues found in triaging this.

  1. error emails were being suppressed due to temporary bouncing, which has now been resolved
  2. it appears that something changed in the response from Google that the oic_login.py extension is not handling. the result is apparently coming back as an html string... rather than some kind of object.
@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Dec 17, 2019

Comparing what's there to the docs for the version of pyoidc we're using it looks like there are some changes that should be considered:

https://github.com/OpenIDC/pyoidc/blob/v0.14.0/doc/examples/rp.rst#authorization-code-flow

@ewdurbin ewdurbin closed this Dec 26, 2019
@isidentical
Copy link
Member

@isidentical isidentical commented Dec 26, 2019

Thanks @ewdurbin, I can confirm it is working now.

@freddrake
Copy link
Member

@freddrake freddrake commented Dec 26, 2019

It's not working for me.

Using my fdrake@gmail.com address, I get the message "There is already an account for fdrake@gmail.com" when returning to bpo.

The Launchpad / Ubuntu One login works just fine.

@freddrake freddrake reopened this Dec 26, 2019
@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Dec 26, 2019

@freddrake it appears that your Google login was disassociated from your account 2015-04-06. was login with google working for you up until ~2 weeks ago when this issue began?

I think that what you're running into is independent of this error.

@freddrake
Copy link
Member

@freddrake freddrake commented Dec 26, 2019

No, it wasn't. Guess it's different.

@freddrake freddrake closed this Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.