Skip to content

bpo-37904: Edition on python tutorial - section 4 #16169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2019

Conversation

umoqnier
Copy link

@umoqnier umoqnier commented Sep 15, 2019

A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith

A little change on first paragraph of python tutorial to be more clearly
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@umoqnier

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the grammar fix, you need to sign the CLA.

@@ -4,8 +4,8 @@
More Control Flow Tools
***********************

Besides the :keyword:`while` statement just introduced, Python knows the usual
control flow statements known from other languages, with some twists.
Besides the :keyword:`while` statement just introduced, Python use the usual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"use" should be "uses".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It's fixed now

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ericvsmith
Copy link
Member

Although now that I think about it, this change is so trivial that I don't think it needs the CLA to be signed. But if you're planning on making other contributions, please consider signing it.

@aeros
Copy link
Contributor

aeros commented Sep 16, 2019

@ericvsmith:

Although now that I think about it, this change is so trivial that I don't think it needs the CLA to be signed. But if you're planning on making other contributions, please consider signing it.

I was under the impression that the CLA had transitioned from a recommendation to strict requirement for any contribution. Is this no longer true?

@tirkarthi
Copy link
Member

3.6 is in security fixes mode. Guess we can remove the label for backport.

@miss-islington miss-islington merged commit b574813 into python:master Sep 17, 2019
@miss-islington
Copy link
Contributor

Thanks @umoqnier for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-16234 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16235 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-16236 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2019
A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith
(cherry picked from commit b574813)

Co-authored-by: Diego Alberto Barriga Martínez <diegobarriga@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2019
A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith
(cherry picked from commit b574813)

Co-authored-by: Diego Alberto Barriga Martínez <diegobarriga@protonmail.com>
ericvsmith pushed a commit that referenced this pull request Sep 18, 2019
A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith
(cherry picked from commit b574813)

Co-authored-by: Diego Alberto Barriga Martínez <diegobarriga@protonmail.com>
ericvsmith pushed a commit that referenced this pull request Sep 18, 2019
A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith
(cherry picked from commit b574813)

Co-authored-by: Diego Alberto Barriga Martínez <diegobarriga@protonmail.com>
ericvsmith pushed a commit that referenced this pull request Sep 18, 2019
A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith
(cherry picked from commit b574813)

Co-authored-by: Diego Alberto Barriga Martínez <diegobarriga@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants