[Skip Issue] Fix a "double decref" in termios_tcgetattr() #10194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Oct 29, 2018
serhiy-storchaka
added
type-bug
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-10210 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit 53835e9) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-10211 is a backport of this pull request to the 3.6 branch. |
|
Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit 53835e9) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit 53835e9) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit 53835e9) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
Hi! The buildbot AMD64 Debian PGO 3.x has failed when building commit 53835e9. You can take a look here: |
|
Do you mind to create a backport for 2.7 @ZackerySpytz? |
|
GH-10218 is a backport of this pull request to the 2.7 branch. |
|
Serhiy, I've created a backport for 2.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"cc" will be decrefed twice if an error occurs in a PyLong_FromLong()
call towards the end of termios_tcgetattr().