Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192) #13200

Merged
merged 3 commits into from Jul 13, 2019
Merged

[3.5] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192) #13200

merged 3 commits into from Jul 13, 2019

Conversation

@gpshead
Copy link
Member

gpshead commented May 8, 2019 •
edited

We updated the server, our testsuite must match.

https://bugs.python.org/issue36816

✈️ CLE -> DEN -> SFO ✈️ #pycon2019 #smoothjazz
(cherry picked from commit 6bd8173)

Authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue36816
@gpshead
[3.5] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192)
Loading status checks…
18d98b1 
We updated the server, our testsuite must match.

https://bugs.python.org/issue36816

✈️ CLE -> DEN ✈️ GH-pycon2019
(cherry picked from commit 6bd8173)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@gpshead
Add the capath copy.
Loading status checks…
f6dab3a 
The 3.5 tree also needed a certificate in the capath directory updated.
The filename for that was determined by `openssl x509 -in $cert.pem -subject_hash`.
@gpshead

This comment has been minimized.

Sign in to view
Copy link
Member Author

gpshead commented May 9, 2019

without this PR, python3.5 -m test.regrtest -u all test_httplib test_ssl will fail due to a certificate mismatch vs the updated cert on our server.
@vstinner vstinner mentioned this pull request May 21, 2019
Merged
@vstinner
vstinner approved these changes May 21, 2019
View changes
Copy link
Member

vstinner left a comment

LGTM.

This PR is needed for PR #13207, an important security fix: prevent HTTP Header Injection.
@larryhastings
Merge branch '3.5' into backport-6bd8173-3.5
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
78ed80d
@larryhastings larryhastings merged commit 221178a into python:3.5 Jul 13, 2019
4 checks passed
4 checks passed
bedevere/issue-number Issue number 36816 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jul 13, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Jul 13, 2019

Thanks for the 3.5 love!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees

@larryhastings larryhastings

Labels
CLA signed sprint type-tests
Projects
None yet
Milestone
No milestone
5 participants
@gpshead @bedevere-bot @larryhastings @vstinner @the-knights-who-say-ni
You can’t perform that action at this time.