[3.6] bpo-35647: Fix path check in cookiejar (GH-11436) #12268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor cookie path check as per RFC 6265 * Add tests for prefix match of path * Add news entry * Fix set_ok_path and refactor tests * Use slice for last letter (cherry picked from commit 0e1f1f0) Co-authored-by: Xtreak <tir.karthi@gmail.com>
orsenthil
approved these changes
Mar 10, 2019
orsenthil
approved these changes
Mar 10, 2019
|
@tirkarthi and @orsenthil: Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor cookie path check as per RFC 6265
Add tests for prefix match of path
Add news entry
Fix set_ok_path and refactor tests
Use slice for last letter
(cherry picked from commit 0e1f1f0)
Co-authored-by: Xtreak tir.karthi@gmail.com
https://bugs.python.org/issue35647