Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34019: Fix wrong arguments for Opera Browser #8047

Merged
merged 1 commit into from Jul 3, 2018
Merged

bpo-34019: Fix wrong arguments for Opera Browser #8047

merged 1 commit into from Jul 3, 2018

Conversation

kbumsik
Copy link
Contributor

@kbumsik kbumsik commented Jul 2, 2018 •
edited by bedevere-bot

@kbumsik kbumsik force-pushed the fix-issue-34019 branch 2 times, most recently from 5e11db8 to 200729d Compare Jul 2, 2018
pablogsal
pablogsal requested changes Jul 2, 2018
View changes
Copy link
Member

@pablogsal pablogsal left a comment •
edited

Thank you @kbumsik for your contribution! The patch LGTM. Just a minor comment regarding the NEWS entry.

Misc/NEWS.d/next/Library/2018-07-02-05-59-11.bpo-34019.ZXJIife.rst Outdated
@@ -0,0 +1,2 @@
webbrowser: Fix the module opens Opera browser with wrong arguments.
Copy link
Member

@pablogsal pablogsal Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this NEWS entry a bit confusing. Maybe we can improve this with something in the lines of:

Correct the arguments passed to the Opera browser when opening a new URL using the ``webbrowser`` module

Copy link
Contributor Author

@kbumsik kbumsik Jul 2, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal Your phrases sounds much batter. Thanks. I updated it.

@bedevere-bot
Copy link

bedevere-bot commented Jul 2, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner reviewed Jul 3, 2018
View changes
Misc/NEWS.d/next/Library/2018-07-02-05-59-11.bpo-34019.ZXJIife.rst Outdated
@@ -0,0 +1,2 @@
Correct the arguments passed to Opera Browser when opening a new URL
Copy link
Member

@vstinner vstinner Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Would you mind to start the entry with "webbrowser: ..."? It's just easier to quickly identify the context of the change, since we have long changelogs between two Python major versions (like 3.6 .. 3.7).

Copy link
Contributor Author

@kbumsik kbumsik Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem :) I added it.

vstinner
vstinner approved these changes Jul 3, 2018
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM, except of a minor suggestion on the NEWS entry.

@pablogsal pablogsal merged commit 3cf1f15 into python:master Jul 3, 2018
@bedevere-bot
Copy link

bedevere-bot commented Jul 3, 2018

@pablogsal: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Jul 3, 2018

Thanks @kbumsik for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 3, 2018

Thanks @kbumsik for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 3, 2018

GH-8063 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2018
@kbumsik @miss-islington
bpo-34019: Fix wrong arguments for Opera Browser (pythonGH-8047)
c9a40fb 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL.
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2018
@kbumsik @miss-islington
bpo-34019: Fix wrong arguments for Opera Browser (pythonGH-8047)
3264691 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL.
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 3, 2018

GH-8064 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Jul 3, 2018
@miss-islington @kbumsik
bpo-34019: Fix wrong arguments for Opera Browser (GH-8047)
dd5f43a 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL.
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
miss-islington added a commit that referenced this pull request Jul 3, 2018
@miss-islington @kbumsik
bpo-34019: Fix wrong arguments for Opera Browser (GH-8047)
cee7b22 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL.
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 5, 2018

Thanks @kbumsik for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 5, 2018

Sorry, @kbumsik and @pablogsal, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3cf1f154edb88c108877729ea09f4ac174697fea 2.7

@kbumsik
Copy link
Contributor Author

kbumsik commented Jul 5, 2018

@pablogsal Should I manage this conflict? I'm not sure if I can do this for you.

@pablogsal
Copy link
Member

pablogsal commented Jul 5, 2018 •
edited

@kbkaiser Don't worry. I will do it myself. :)

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Jul 5, 2018
@kbumsik @pablogsal
[2.7] bpo-34019: Fix wrong arguments for Opera Browser (pythonGH-8047)
624f7bf 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL..
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 5, 2018

GH-8126 is a backport of this pull request to the 2.7 branch.

pablogsal added a commit that referenced this pull request Jul 6, 2018
@pablogsal @kbumsik
[2.7] bpo-34019: Fix wrong arguments for Opera Browser (GH-8047) (#8126)
8902a1d 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL..
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@kbumsik @yahya-abou-imran
bpo-34019: Fix wrong arguments for Opera Browser (python#8047)
c926083 
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@pablogsal pablogsal

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kbumsik @bedevere-bot @miss-islington @pablogsal @vstinner @the-knights-who-say-ni