[3.6] bpo-28655: Fix test bdb for isolate mode #10220
Conversation
Fix test_bdb when running Python is isolated mode. (cherry picked from commit c0799ec)
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
maigimenez
changed the title
|
FYI I am mentoring @maigimenez and I asked her to fix the few tests in Python 3.6 which break when Python is run in isolated mode. Tests are fine in 3.7 and newer. |
LGTM. I confirm that the change fix test_bdb as expected.
vstinner@apu$ ./python -m test test_bdb
...
Tests result: SUCCESS
vstinner@apu$ ./python -I -m test test_bdb
...
Tests result: FAILURE
vstinner@apu$ git pr 10220 # download this PR
vstinner@apu$ ./python -I -m test test_bdb # it works!
...
Tests result: SUCCESS
|
I will merge this PR once you sign the CLA and the PSF will review your signature. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Fix test_bdb when running Python is isolated mode (python3 -I).
https://bugs.python.org/issue28655