Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. #17620

Open
wants to merge 4 commits into
base: master
from
Open

bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. #17620

wants to merge 4 commits into from
+30 −0

Conversation

@maxking
Copy link
Contributor

maxking commented Dec 16, 2019 •
edited by bedevere-bot

In certain malformed content-disposition headers, parameter values are quoted
and split as encoded words on two lines with extra whitespaces. This fixes the
issue by removing the extra whitespace between the two encoded words.

https://bugs.python.org/issue39040
@maxking
bpo-39040: Fix parsing of email headers with whitespace between encod…
Verified
This commit was signed with a verified signature.
maxking Abhilash Raj
GPG key ID: 9D9B2BA061D0A67C Learn about signing commits
Loading status checks…
9da6ddf 
…ed-words.

In certain malformed content-disposition headers, parameter values are quoted
and split as encoded words on two lines with extra whitespaces. This fixes the
issue by removing the extra whitespace between the two encoded words.
@maxking maxking requested a review from python/email-team as a code owner Dec 16, 2019
@bitdancer
bitdancer reviewed Dec 16, 2019
View changes
Lib/email/_header_value_parser.py Outdated Show resolved Hide resolved
@bitdancer
bitdancer reviewed Dec 16, 2019
View changes
Lib/email/_header_value_parser.py Outdated Show resolved Hide resolved
@bitdancer
bitdancer reviewed Dec 16, 2019
View changes
Lib/test/test_email/test_headerregistry.py Outdated Show resolved Hide resolved
@bitdancer
bitdancer reviewed Dec 16, 2019
View changes
Misc/NEWS.d/next/Library/2019-12-15-18-47-20.bpo-39040.tKa0Qs.rst Outdated Show resolved Hide resolved
@bitdancer
bitdancer requested changes Dec 16, 2019
View changes
Copy link
Member

bitdancer left a comment

Oops, I forgot to start a review :(
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 16, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
@maxking maxking changed the title bpo-39040: Fix parsing of email headers with whitespace between encoded-words. bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. Dec 17, 2019
@maxking
Remove empty lines, add a new test and update the news entry.
Verified
This commit was signed with a verified signature.
maxking Abhilash Raj
GPG key ID: 9D9B2BA061D0A67C Learn about signing commits
Loading status checks…
bf2cb76
@maxking

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

maxking commented Dec 17, 2019

I have made the requested changes; please review again.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 17, 2019

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from bitdancer Dec 17, 2019
@bitdancer
bitdancer requested changes Dec 17, 2019
View changes
Lib/test/test_email/test_headerregistry.py Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 17, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
maxking added 2 commits Dec 18, 2019
@maxking
Update test to include spaces around an encoded word.
Verified
This commit was signed with a verified signature.
maxking Abhilash Raj
GPG key ID: 9D9B2BA061D0A67C Learn about signing commits
Loading status checks…
004f37d
@maxking
Fix the encoded word syntax and resultant error.
Verified
This commit was signed with a verified signature.
maxking Abhilash Raj
GPG key ID: 9D9B2BA061D0A67C Learn about signing commits
Loading status checks…
016ceb3
@maxking

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

maxking commented Dec 18, 2019

I have made the requested changes; please review again.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 18, 2019

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from bitdancer Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdancer bitdancer

Assignees
No one assigned
Labels
CLA signed awaiting change review needs backport to 3.7 needs backport to 3.8 type-bugfix
Projects
None yet
Milestone
No milestone
4 participants
@maxking @bedevere-bot @bitdancer @the-knights-who-say-ni
You can’t perform that action at this time.