bpo-34303: Micro-optimizations in functools.reduce() #8598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Aug 3, 2018
Modules/_functoolsmodule.c
Outdated
| PyTuple_SetItem(args, 1, op2); | ||
| if ((result = PyEval_CallObject(func, args)) == NULL) | ||
| Py_XSETREF(PyTuple_GET_ITEM(args, 0), result); | ||
| Py_XSETREF(PyTuple_GET_ITEM(args, 1), op2); |
There was a problem hiding this comment.
Does PyTuple_GET_ITEM guarantee its result is an lvalue? That's not in the public API anywhere.
PySequence_Fast_ITEMS(args)[0] would be conforming to the public API, and I think just as fast
There was a problem hiding this comment.
I fixed it, PySequence_Fast_ITEMS() seems to be slower as it checks for type.
sir-sigurd
force-pushed
the
functools-reduce-performance
branch
from
4a0bca9 to
f491abf
Compare
methane
changed the title
methane
approved these changes
Feb 18, 2019
|
@methane, was there any blocker on merging this? Thanks! |
@rhettinger would you review this? |
rhettinger
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34303