Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[3.6] bpo-36564: Fix infinite loop in email folding logic (GH-12732) #14799
Conversation
As far as I can tell, this infinite loop would be triggered if: 1. The value being folded contains a single word (no spaces) longer than max_line_length 2. The max_line_length is shorter than the encoding's name + 9 characters. bpo-36564: https://bugs.python.org/issue36564 (cherry picked from commit f69d5c6) Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
warsaw
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The failure is due to:
The Linux builds on Azure and Travis went through without any errors. Maybe we need to restart the build on Appveyor. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for looking into it. I wouldn’t worry about the failure. I will take a look and presumably merge the PR later when I’m back from holiday. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Sorry, I can't merge this PR. Reason: |
ned-deily
merged commit 79a47e2
into
python:3.6
miss-islington commentedJul 16, 2019
•
edited by bedevere-bot
As far as I can tell, this infinite loop would be triggered if:
max_line_length
characters.
bpo-36564: https://bugs.python.org/issue36564
(cherry picked from commit f69d5c6)
Co-authored-by: Paul Ganssle pganssle@users.noreply.github.com
https://bugs.python.org/issue36564