Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Fix typo in C API documentation. (GH-17696) #17699

Merged
merged 1 commit into from Dec 25, 2019
Merged

Conversation

@benjaminp
Copy link
Contributor

benjaminp commented Dec 25, 2019

No description provided.

The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix.
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Dec 25, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@WillAyd

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@benjaminp benjaminp merged commit 362ede2 into 2.7 Dec 25, 2019
4 checks passed
4 checks passed
bedevere/issue-number Issue report skipped
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjaminp benjaminp deleted the backport-5c7ed75-2.7 branch Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.