Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-22640: Fix function signature of quiet in docs #17719

Merged
merged 1 commit into from Dec 28, 2019
Merged

bpo-22640: Fix function signature of quiet in docs #17719

merged 1 commit into from Dec 28, 2019
+1 −1

Conversation

@isidentical
Copy link
Contributor

isidentical commented Dec 27, 2019 •
edited by bedevere-bot

just a trivial fix for the signature, i guess this needs backport to 3.8

https://bugs.python.org/issue22640
@isidentical
bpo-38731: Fix function signature of quiet in docs
Loading status checks…
d2eefdb
@isidentical isidentical changed the title bpo-38731: Fix function signature of quiet in docs bpo-22640: Fix function signature of quiet in docs Dec 27, 2019
@pablogsal pablogsal added the skip news label Dec 28, 2019
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 28, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@pablogsal pablogsal dismissed a stale review Dec 28, 2019

I just wanted to comment, not request changes

@pablogsal
pablogsal approved these changes Dec 28, 2019
View changes
Copy link
Member

pablogsal left a comment

LGTM

I have to say that quiet being an integer is a bit confusing, but this does not apply to this PR :)
@pablogsal pablogsal merged commit 98f0f04 into python:master Dec 28, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191227.22 succeeded
Details
bedevere/issue-number Issue number 22640 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 28, 2019

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 28, 2019

GH-17725 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Dec 28, 2019
@miss-islington @isidentical
bpo-38731: Fix function signature of quiet in docs (GH-17719)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04c1efe 
(cherry picked from commit 98f0f04)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@isidentical @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.