Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39121: write gzip header OS information #17682

Open
wants to merge 8 commits into
base: master
from

Conversation

@wungad
Copy link

wungad commented Dec 23, 2019

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Dec 23, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@wungad

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Misc/ACKS Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
wungad added 3 commits Dec 23, 2019
Copy link
Author

wungad left a comment

All changes implemented.

@wungad wungad requested review from corona10 and serhiy-storchaka Dec 25, 2019
Lib/gzip.py Outdated
@@ -17,6 +17,15 @@

READ, WRITE = 1, 2

# OS field values as specified in RFC 1952
OS_CODES = {

This comment has been minimized.

Copy link
@corona10

corona10 Dec 27, 2019

Member

If values such as OS_CODES does not intend to expose as the public constants.
I'd like to recommend to change OS_CODES into _OS_CODES also for OS_UNIX, OS_NTFS.

what do you think @serhiy-storchaka ?

This comment has been minimized.

Copy link
@wungad

wungad Dec 27, 2019

Author

I agree. There is no need to expose them since they are specific to gzip header only.

This comment has been minimized.

Copy link
@wungad

wungad Dec 27, 2019

Author

Fixed in 9db21eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.