Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[easy] Move _releaseLock() into `finally` #17689
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 24, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
DerekTBrown
force-pushed the
DerekTBrown:logging_deadlock
branch
2 times, most recently
from
53e9f6b
to
9509cc9
DerekTBrown
changed the title
DerekTBrown
force-pushed the
DerekTBrown:logging_deadlock
branch
from
9509cc9
to
d9dbc31
DerekTBrown
force-pushed the
DerekTBrown:logging_deadlock
branch
from
d9dbc31
to
7b778d6
This comment has been minimized.
This comment has been minimized.
|
I just signed CLA. |
DerekTBrown commentedDec 24, 2019
•
edited
This is a relatively small change which makes it easier to reason about the global
_acquireLock()behavior inside ofisEnabledFor:_releaseLockinside of afinallyblock, ensuring that the lock is released even if exceptions are thrown (Example). This diff's primary goal is to ensure_releaseLockis called inside a finally block.isEnabledFor, because we no longer need to assert than no exceptions are thrown in order for the lock to be released.stopit, this ensures the lock is released even if exceptions are injected.trystatements are stylistically bad. Instead, create a helper function to contain the uncached behavior of determining if a logger is enabled for a particular status.