Skip to content

Doc: add list(dict) in stdtypes library #16209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

adorilson
Copy link
Contributor

Doc about list(dict) was missing in stdtypes library.

Maybe we must add something in Dictionary view objects section, too.
But, I'm not sure.

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @adorilson

I think this could be a helpful addition, but it should be below the entry for iter(d) rather than at the top of the list. Those two are functionally similar to each other.

Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

@matrixise matrixise merged commit 63dedef into python:master Sep 17, 2019
@miss-islington
Copy link
Contributor

Thanks @adorilson for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2019
(cherry picked from commit 63dedef)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
@bedevere-bot
Copy link

GH-16210 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2019
(cherry picked from commit 63dedef)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
@bedevere-bot
Copy link

GH-16211 is a backport of this pull request to the 3.7 branch.

matrixise pushed a commit that referenced this pull request Sep 17, 2019
(cherry picked from commit 63dedef)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
matrixise pushed a commit that referenced this pull request Sep 17, 2019
(cherry picked from commit 63dedef)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
@matrixise
Copy link
Member

Thank you for your PR.

@adorilson adorilson deleted the list_from__dict branch March 25, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants