Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39114: Fix handling of line numbers around finally-blocks. #17737
+1,692
−1,622
Conversation
This comment has been minimized.
This comment has been minimized.
|
You need to regenerate the frozen importlib and other frozen stuff, no? ( |
markshannon
force-pushed the
markshannon:fix-linenumbers-around-finallly-blocks
branch
from
f3b9fbe
to
f254546
|
Looks good to me. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markshannon commentedDec 29, 2019
•
edited by bedevere-bot
Restores the line number after emitting the code for a finally block.
https://bugs.python.org/issue39114