Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38588: Fix segfaults when dict comparison with modifying operand #17734
Conversation
This comment has been minimized.
This comment has been minimized.
Could you include the rest of the cases that LCatro was mentioning? He mentioned another 2 for lists. |
This comment has been minimized.
This comment has been minimized.
poc3 is not reproducible on my local mac machine and Linux machine with the master branch. Line 452 in 3c87a66 However poc2 is reproducible, so I will add the patch on this PR. $ cat poc3.py
class poc() :
def __eq__(self,other) :
list1.clear()
return NotImplemented
list1 = [ set() ]
poc() in list1
print('end')
$ ./python poc3.py
end |
This comment has been minimized.
This comment has been minimized.
FWIW, LCatro had opened another issue (https://bugs.python.org/issue38610) for similar crashes in the |
This comment has been minimized.
This comment has been minimized.
@pablogsal And for the And IMHO, we can close bpo-38588 with this patch |
corona10 commentedDec 29, 2019
•
edited by bedevere-bot
Based on LCatro's report
https://bugs.python.org/issue38588