Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-22593: Automate update of Unicode data version in documentation #17748

Open
wants to merge 2 commits into
base: master
from
Open

bpo-22593: Automate update of Unicode data version in documentation #17748

wants to merge 2 commits into from
+42 −9

Conversation

@nmassman
Copy link

nmassman commented Dec 30, 2019 •
edited by bedevere-bot

Added a sphinx extension and modified makeunicodedata.py to automate updating documentation with the current Unicode version when it changes.

https://bugs.python.org/issue22593
@nmassman
bpo-22593: Automate update of unicode data version in documentation
Loading status checks…
aadb75c
@nmassman nmassman mentioned this pull request Dec 30, 2019
Open
@nmassman
Fix whitespace in makeunicodedata.py
Loading status checks…
70e3c28
@aeros
aeros suggested changes Dec 30, 2019
View changes
Copy link
Member

aeros left a comment

Thanks for the PR @nmassman and welcome!

I agree with the general idea behind the PR, it doesn't seem practical to maintain the latest Unicode version in 6 different locations, or for additional ones that are added in the future.

However, a few points (I might think of more later):

  1. You could store the version as a global constant in conf.py, I don't think we need a dedicated text file just to store the latest unicode version.
  2. UNICODE_VERSION or UCS_VERSION would be a far more explicit name for the constant. As far as I'm aware, "UCD" is not a commonly known acronym for Unicode.
  3. IANAL, but I believe there are legal issues associated with copyrighting your own file additions. Our primary means of providing credit/acknowledgement to contributors these days is by adding a Contributed by <name>. sentence at the end of the news entry for the PR. You can add this in yourself.

/cc @merwok
@aeros aeros requested a review from merwok Dec 30, 2019
@ned-deily ned-deily requested a review from JulienPalard Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros

@JulienPalard JulienPalard

@merwok merwok

Assignees
No one assigned
Labels
CLA signed awaiting core review type-documentation
Projects
None yet
Milestone
No milestone
4 participants
@nmassman @aeros @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.