Skip to content

[2.7] bpo-33899: Revert tokenize module adding an implicit final NEWLINE #10072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Oct 24, 2018

Since this breaks backwards compatibility, this is being reverted to avoid breaking existing code.

This reverts the backport PR GH-8133.

https://bugs.python.org/issue33899

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@taleinat taleinat changed the base branch from master to 2.7 October 24, 2018 06:05
@taleinat taleinat closed this Oct 24, 2018
@taleinat taleinat reopened this Oct 24, 2018
@taleinat taleinat closed this Oct 24, 2018
@taleinat taleinat changed the title bpo-33899: Revert tokenize module adding an implicit final NEWLINE [2.7] bpo-33899: Revert tokenize module adding an implicit final NEWLINE Oct 24, 2018
@taleinat taleinat reopened this Oct 24, 2018
@taleinat taleinat removed request for a team, gpshead, 1st1, rhettinger and skrah October 24, 2018 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants