Skip to content

bpo-31292: Fixed distutils check --restructuredtext for include directives #10605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 27, 2019
Merged

bpo-31292: Fixed distutils check --restructuredtext for include directives #10605

merged 10 commits into from
Mar 27, 2019

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Nov 20, 2018

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@flying-sheep
Copy link
Contributor Author

The warning that makes the tests fail doesn’t come from my code. IDK how that can be solved.

@ned-deily
Copy link
Member

The warning that makes the tests fail doesn’t come from my code.

@flying-sheep: It's coming from your NEWS entry, generated with blurb. You can reproduce in your working directory by:

cd Doc
make venv
make suspicious

To see how the changelog would look, try:

make html

and then open build/html/whatsnew/changelog.html in your browser.
You can either tweak the NEWS entry so it passes the suspicious test or the line can be added to Doc/tools/susp-ignored.csv

@flying-sheep
Copy link
Contributor Author

OK, thank you, very helpful!

I’d gladly have added the “full line with context” to the susp-ignored.csv, but that didn’t work. I had to add only .. include ::.

@merwok
Copy link
Member

merwok commented Jan 13, 2019

IMO the first option would be better: write the ``include`` directive in the news entry.

@flying-sheep
Copy link
Contributor Author

OK! It’s done.

@csabella csabella merged commit d5a5a33 into python:master Mar 27, 2019
@miss-islington
Copy link
Contributor

Thanks @flying-sheep for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12593 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-12594 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2019
…tives (pythonGH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2019
…tives (pythonGH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington added a commit that referenced this pull request Mar 27, 2019
…tives (GH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington added a commit that referenced this pull request Mar 27, 2019
…tives (GH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
@flying-sheep flying-sheep deleted the bpo-31292 branch March 28, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants