Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39114: Fix tracing of except handlers with name binding #17769

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39114: Fix tracing of except handlers with name binding #17769

wants to merge 1 commit into from
+0 −4

Conversation

@pablogsal
Copy link
Member

pablogsal commented Dec 31, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue39114
@pablogsal
bpo-39114: Fix tracing of except handlers with name binding
Verified
This commit was signed with a verified signature.
pablogsal Pablo Galindo
GPG key ID: FFE87404168BD847 Learn about signing commits
Loading status checks…
8b8f4a7
@pablogsal pablogsal requested a review from markshannon Dec 31, 2019
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member Author

pablogsal commented Dec 31, 2019

@nedbat Can you confirm if this fixes your issue?
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member Author

pablogsal commented Dec 31, 2019

@markshannon Can you check if this looks right to you? I am not completely sure what was the original purpose of this code (not sure what the comment Make sure that we trace line after exception is referring to) but looks like this is what is making the trace function emit incorrect lines after the artificial finally of the try-except with name to delete de name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
3 participants
@pablogsal @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.