Perfect your code

With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.

Sign up for free See pricing for teams and enterprises

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33764: Appveyor fixes #7364

Merged

ned-deily merged 3 commits into python:master from zware:appveyor_fixes

Jun 4, 2018

+5 −4

Member

zware commented Jun 3, 2018 •

edited by bedevere-bot

https://bugs.python.org/issue33764

zware added 3 commits


        Prevent spurious message if taking a shortcut

235ade5


        Fix YAML style

41d7cea


        Disable largefile tests

e0fd985

zware added needs backport to 3.6 needs backport to 2.7 OS-windows skip issue skip news needs backport to 3.7 labels

zware self-assigned this

bedevere-bot added the awaiting merge label

the-knights-who-say-ni added the CLA signed label

Member Author

zware commented Jun 3, 2018

It appears that AppVeyor is not accepting builds from us at the moment; I'm not sure why. I've tested this on my own clone (zware#8), though, and from a sample size of one it appears to both speed up the build and prevent the crash.

@terryjreedy if this comes unblocked and I haven't already done it, please feel free to merge.

ned-deily mentioned this pull request

bpo-33764: Disable largefile on AppVeyor #7368

Closed

vstinner changed the title ~~Appveyor fixes~~ bpo-33764: Appveyor fixes

Member

vstinner commented Jun 4, 2018

I closed my PR #7368 as a duplicate of this one.

Member

vstinner commented Jun 4, 2018

And now we cannot merge this PR because of https://bugs.python.org/issue33765 ? AppVeyor, you are not funny with us :-( Is a Python release manager allowed to merge such change? @ned-deily?

ned-deily merged commit 47a6c79 into python:master

8 checks passed

8 checks passed

VSTS: Linux-PR Linux-PR_20180603.39 succeeded

Details

VSTS: Linux-PR-Coverage Linux-PR-Coverage_20180603.41 succeeded

Details

VSTS: Windows-PR Windows-PR_20180603.39 succeeded

Details

VSTS: docs docs_20180603.48 succeeded

Details

VSTS: macOS-PR macOS-PR_20180603.39 succeeded

Details

bedevere/issue-number Issue number 33764 found

Details

bedevere/news "skip news" label found

continuous-integration/travis-ci/pr The Travis CI build passed

Details

miss-islington commented Jun 4, 2018

Thanks @zware for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

bedevere-bot commented Jun 4, 2018

GH-7369 is a backport of this pull request to the 3.7 branch.

bedevere-bot removed the needs backport to 3.7 label

miss-islington added a commit to miss-islington/cpython that referenced this pull request


        bpo-33764: Appveyor fixes (pythonGH-7364)

04bb87e

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
(cherry picked from commit 47a6c79)

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>

miss-islington commented Jun 4, 2018

Sorry, @zware and @ned-deily, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 47a6c79f0986ce9a84d0efc3c565b28255042911 2.7

miss-islington assigned ned-deily and unassigned zware

Member

vstinner commented Jun 4, 2018

It would be nice to see a new AppVeyor build with this new configuration, before merging backports.

miss-islington commented Jun 4, 2018

Sorry, @zware and @ned-deily, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 47a6c79f0986ce9a84d0efc3c565b28255042911 3.6

ned-deily added a commit that referenced this pull request


        bpo-33764: Appveyor fixes (GH-7364) (GH-7369)

37343a2

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
(cherry picked from commit 47a6c79)

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>

ned-deily added a commit to ned-deily/cpython that referenced this pull request


        bpo-33764: Appveyor fixes (pythonGH-7364)

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests

bedevere-bot removed the needs backport to 3.6 label

bedevere-bot commented Jun 4, 2018

GH-7379 is a backport of this pull request to the 3.6 branch.

ned-deily added a commit to ned-deily/cpython that referenced this pull request


        bpo-33764: Appveyor fixes (pythonGH-7364)

a23f404

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests

bedevere-bot commented Jun 4, 2018

GH-7380 is a backport of this pull request to the 2.7 branch.

bedevere-bot removed the needs backport to 2.7 label

ned-deily added a commit that referenced this pull request


        bpo-33764: Appveyor fixes (GH-7364) (GH-7379)

b8f2fb5

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests

ned-deily added a commit that referenced this pull request


        bpo-33764: Appveyor fixes (GH-7364) (GH-7380)

1cbdbf3

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests

zware deleted the zware:appveyor_fixes branch

lisroach added a commit to lisroach/cpython that referenced this pull request


        bpo-33764: Appveyor fixes (pythonGH-7364)

571be29

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests

yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request


        bpo-33764: Appveyor fixes (pythonGH-7364)

63032ab

* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.