Skip to content

bpo-29750: support non-ASCII passwords in smtplib #15064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

bpo-29750: support non-ASCII passwords in smtplib #15064

wants to merge 3 commits into from

Conversation

Windsooon
Copy link
Contributor

@Windsooon Windsooon commented Aug 1, 2019 •
edited by bedevere-bot
Loading

issue: https://bugs.python.org/issue29750

I updated the PR based on the review from #8938

https://bugs.python.org/issue29750

@Windsooon Windsooon requested a review from a team as a code owner August 1, 2019 04:11
@Windsooon
Copy link
Contributor Author

Please review this PR when you have time @taleinat :D

@ZackerySpytz
Copy link
Contributor

You don't need to create a new PR in order to address review comments. Just update the original PR.

@Windsooon
Copy link
Contributor Author

Hello, @ZackerySpytz , I use a wrong branch name at the very beginning then deleted it locally by mistake. That is why I use a new PR here.

@seblu
Copy link

seblu commented Dec 26, 2019

Python 3.8.0 is still impacted by this.

Patched version 3.8.0 accept passwords with utf8 chars.

@csabella csabella requested review from taleinat and maxking May 28, 2020 23:19
@Leon-001
Copy link

Leon-001 commented Jan 4, 2021

Hi,
I just wanted to give some motivation: I had a special character in my password and it took some time until I have figured out, what was going on. It would be great, if this patch could be reviewed!
Thank you all!

@max-toepfer
Copy link

Hello, lovely Python dev folks,
as another affected individual I wanted to ask, if this topic is still alive?
Thank you so much for the contributions!

@david david mannequin mentioned this pull request Apr 30, 2022
Open
@MaxwellDupre
Copy link
Contributor

Let smtplib support non-ASCII passwords, better
smtplib support for UTF-8 passwords

@arhadthedev
Copy link
Member

Closing in favor of SASLprep-based gh-103611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jourdelune Jourdelune Jourdelune approved these changes

@taleinat taleinat Awaiting requested review from taleinat

@maxking maxking Awaiting requested review from maxking

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.