Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37446: resolve undefined behavior in Python/hamt.c #17727

Merged
merged 2 commits into from Dec 31, 2019
Merged

bpo-37446: resolve undefined behavior in Python/hamt.c #17727

merged 2 commits into from Dec 31, 2019

Conversation

@isidentical
Copy link
Contributor

isidentical commented Dec 28, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue37446
@isidentical
bpo-37446: resolve undefined behavior in Python/hamt.c
Loading status checks…
38d47de
@isidentical isidentical requested a review from 1st1 as a code owner Dec 28, 2019
@benjaminp
benjaminp reviewed Dec 28, 2019
View changes
Python/hamt.c Outdated Show resolved Hide resolved
@isidentical
use suffix directly instead of macro
Loading status checks…
6ce310b
@isidentical isidentical requested a review from benjaminp Dec 29, 2019
@corona10 corona10 added the skip news label Dec 30, 2019
@corona10
corona10 approved these changes Dec 30, 2019
View changes
@benjaminp benjaminp merged commit d0c92e8 into python:master Dec 31, 2019
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191229.7 succeeded
Details
bedevere/issue-number Issue number 37446 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 31, 2019

Thanks @isidentical for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 31, 2019

GH-17767 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Dec 31, 2019
@miss-islington @isidentical
closes bpo-37446: resolve undefined behavior in Python/hamt.c (GH-17727)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a278ae1 
(cherry picked from commit d0c92e8)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@benjaminp benjaminp

@1st1 1st1

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@isidentical @miss-islington @bedevere-bot @benjaminp @corona10 @the-knights-who-say-ni
You can’t perform that action at this time.