Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue39165][bpo-39165][Lib/re] implement findalliter() and findfirst() #17735

Open
wants to merge 2 commits into
base: master
from

Conversation

@apalala
Copy link

apalala commented Dec 29, 2019

  • Implement findfirst() in terms of first() and findalliter().
  • Reimplement findall(...) as return list(findalliter(...))

https://bugs.python.org/issue39165

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Dec 29, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@apalala

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi

This comment has been minimized.

Copy link
Contributor

tirkarthi commented Dec 29, 2019

The code change introduces new API that needs to be discussed. Please open an issue at https://bugs.python.org

@apalala

This comment has been minimized.

Copy link
Author

apalala commented Dec 30, 2019

Reported as enhancement in https://bugs.python.org/issue39165

@apalala apalala changed the title [lib/re] implement findalliter() and findfirst() [bpo-39165][Lib/re] implement findalliter() and findfirst() Dec 30, 2019
@apalala apalala changed the title [bpo-39165][Lib/re] implement findalliter() and findfirst() [issue39165][bpo-39165][Lib/re] implement findalliter() and findfirst() Dec 30, 2019
@apalala

This comment has been minimized.

Copy link
Author

apalala commented Dec 30, 2019

Note that this PR is incomplete as it does not implement Pattern.findalliter() nor Pattern.findfirst().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.