Skip to content

bpo-34749: Improved performance of binascii.a2b_base64(). #9444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2019
Merged

bpo-34749: Improved performance of binascii.a2b_base64(). #9444

merged 2 commits into from
Jul 14, 2019

Conversation

sir-sigurd
Copy link
Contributor

@sir-sigurd sir-sigurd commented Sep 20, 2018 •
edited by bedevere-bot
Loading

@sir-sigurd sir-sigurd force-pushed the a2b_base64 branch 2 times, most recently from b2f9c45 to 7593233 Compare September 21, 2018 07:52
@csabella csabella requested a review from encukou May 22, 2019 19:17
@csabella
Copy link
Contributor

csabella commented May 22, 2019 •
edited by bedevere-bot
Loading

@encukou, there are now merge conflicts between this and GH-4108 (bpo-31862). Do you think the changes here would be compatible with the other changes being proposed for upcoming PEPs? Thanks!

@encukou
Copy link
Member

encukou commented May 23, 2019

The conflicts look minor (though Git rightly thinks they're better left to humans). I don't know about all upcoming PEPs, but I'm not aware of conflicts.
Unfortunately I won't have time for review in the next few months :(

@csabella
Copy link
Contributor

@encukou, thank you for the response. This one may need to wait a little longer until a reviewer is available then.

encukou
encukou approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased on top of the module state changes in master.
I can still see the speedup, can't find any new bugs, and I haven't been able to speed it up more :)

@miss-islington
Copy link
Contributor

@sir-sigurd: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1c5e68e into python:master Jul 14, 2019
@sir-sigurd sir-sigurd deleted the a2b_base64 branch July 14, 2019 13:36
@sir-sigurd
Copy link
Contributor Author

@encukou, thanks for rebasing it!

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@sir-sigurd @lisroach
bpo-34749: Improved performance of binascii.a2b_base64(). (pythonGH-9444
6a5d361 
)

https://bugs.python.org/issue34749
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@sir-sigurd @DinoV
bpo-34749: Improved performance of binascii.a2b_base64(). (pythonGH-9444
116207e 
)

https://bugs.python.org/issue34749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sir-sigurd @csabella @encukou @miss-islington @the-knights-who-say-ni @bedevere-bot