Skip to content

bpo-37165: Convert _count_elements to the argument clinic #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2019
Merged

bpo-37165: Convert _count_elements to the argument clinic #13848

merged 3 commits into from
Jun 5, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Jun 5, 2019 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added the performance Performance or resource usage label Jun 5, 2019
pablogsal
pablogsal reviewed Jun 5, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this :)

I left some comments regarding a couple of missing things.

pablogsal
pablogsal approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhettinger rhettinger merged commit e985804 into python:master Jun 5, 2019
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-13853 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 5, 2019
@miss-islington @rhettinger
bpo-37165: Convert _count_elements to the argument clinic (GH-13848)
21ce245 
(cherry picked from commit e985804)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@serhiy-storchaka
Copy link
Member

Usually we do not add a NEWS entry when convert a module or separate functions to Argument Clinic, as such conversion does not change the behavior. In this particular case the converted function is private, so there is even less reasons to add a NEWS entry.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-37165: Convert _count_elements to the argument clinic (pythonGH-1…
4e5ad6c 
…3848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhettinger @miss-islington @bedevere-bot @serhiy-storchaka @pablogsal @the-knights-who-say-ni