Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-39162 fix a logic bug in the Tcl/Tk include scanner for macOS in setup.py #17753
+7
−8
Conversation
…ested for existence, it's then later added to the include
| for fw in 'Tcl', 'Tk': | ||
| if is_macosx_sdk_path(F): | ||
| if not exists(join(sysroot, F[1:], fw + '.framework')): |
This comment has been minimized.
This comment has been minimized.
tonybaloney
Dec 30, 2019
Author
Contributor
Currently, this condition would match, because in macOS 10.15 /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Tk.framework exists, however, F is not the path that it's checking, so it adds /System/Library/Frameworks/Tk.framework to the list of include_dirs
This comment has been minimized.
This comment has been minimized.
|
Wow, this function hasn't been touched in a really long time. requesting reviews from @ned-deily and @brettcannon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tonybaloney commentedDec 30, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39162