Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fixes in urllib.parse #17745

Merged
merged 1 commit into from Dec 31, 2019
Merged

Minor doc fixes in urllib.parse #17745

merged 1 commit into from Dec 31, 2019
+27 −26

Conversation

@verhovsky
Copy link
Contributor

verhovsky commented Dec 30, 2019 •
edited by miss-islington

Automerge-Triggered-By: @csabella
@verhovsky
Minor doc fixes in urllib.parse
Loading status checks…
375b29a
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor

csabella commented Dec 31, 2019

@verhovsky, thank you for your contribution. I agree with your suggested changes. For the future, this many changes probably could have had a ticket on the bug tracker. Having a ticket raises the visibility of issues, so you have a better chance of a core dev seeing the PR.
@csabella
csabella approved these changes Dec 31, 2019
View changes
Copy link
Contributor

csabella left a comment

LGTM
@miss-islington miss-islington merged commit 8e1f26e into python:master Dec 31, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191230.1 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 31, 2019

Thanks @verhovsky for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 31, 2019

Sorry, @verhovsky, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e1f26e4f06c43cf52afa26ce30f27d2c1129c4a 3.8
@miss-islington miss-islington self-assigned this Dec 31, 2019
sthagen added a commit to sthagen/cpython that referenced this pull request Dec 31, 2019
@sthagen
Merge pull request #132 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d6edd7f 
Minor doc fixes in urllib.parse (pythonGH-17745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

Assignees

@miss-islington miss-islington

Labels
🤖 automerge CLA signed needs backport to 3.8 skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@verhovsky @csabella @miss-islington @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.