Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) #16685

Merged
merged 1 commit into from Oct 9, 2019
Merged

[3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) #16685

merged 1 commit into from Oct 9, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 9, 2019 •
edited

  • bpo-38379: when a finalizer resurrects an object,
    nothing is actually collected in this run of gc.
    Change the stats to relect that truth..
    (cherry picked from commit ecbf35f)

Co-authored-by: Tim Peters tim.peters@gmail.com

https://bugs.python.org/issue38379

Automerge-Triggered-By: @pablogsal

@bedevere-bot bedevere-bot mentioned this pull request Oct 9, 2019
Merged
@pablogsal pablogsal mentioned this pull request Oct 9, 2019
Merged
@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Oct 9, 2019
@pablogsal pablogsal requested a review from tim-one Oct 9, 2019
@pablogsal pablogsal changed the title [3.7] bpo-38379: don't claim objects are collected when they aren't … [3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) Oct 9, 2019
@pablogsal
Copy link
Member Author

pablogsal commented Oct 9, 2019

I'm fixing the errors from the merge conflicts

tim-one
tim-one approved these changes Oct 9, 2019
View changes
Copy link
Member

@tim-one tim-one left a comment

Perfect - thank you again 😃

@tim-one @pablogsal
[3.7] bpo-38379: don't claim objects are collected when they aren't (p…
92fab65 
…ythonGH-16658)

* bpo-38379:  when a finalizer resurrects an object,
nothing is actually collected in this run of gc.
Change the stats to relect that truth..
(cherry picked from commit ecbf35f)

Co-authored-by: Tim Peters <tim.peters@gmail.com>
@tim-one
Copy link
Member

tim-one commented Oct 9, 2019

Looks like the for loop opener needs to be changed for 3.7 ☹️ ... and looks like you already did that!

@pablogsal
Copy link
Member Author

pablogsal commented Oct 9, 2019

Looks like the for loop opener needs to be changed for 3.7 frowning_face ... and looks like you already did that!

Yeah, for some reason I did not push correctly my latest fixes for the merge conflicts. Apologies for the confusion!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 9, 2019

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit a081e93 into python:3.7 Oct 9, 2019
5 checks passed
@pablogsal pablogsal deleted the backport-ecbf35f-3.7 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-one tim-one

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @tim-one @miss-islington @the-knights-who-say-ni @bedevere-bot